Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create result.html #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create result.html #8

wants to merge 1 commit into from

Conversation

PinkLasagna1
Copy link

No description provided.

joelleoqiyi
joelleoqiyi requested changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@joelleoqiyi joelleoqiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PinkLasagna1!!

Could you make the following edits before we can accept your submission!

  1. change the name of the file from result.html to a more appropriate name such as check_weather_based_on_location.html

Screenshot 2020-10-22 at 12 30 26 PM
the formatting of your website looks rather weird. could you do some slight editing to make it look nicer. For eg: I believe beside Key in your country:, there should be a textbox?

thanks! (if you need help pls feel free to reply to this thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelleoqiyi joelleoqiyi joelleoqiyi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PinkLasagna1 @joelleoqiyi