Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-export of __init__ imports with __all__ #146

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

warlo
Copy link
Contributor

@warlo warlo commented Feb 11, 2023

Had this issue with mypy in strict mode and figured it could make sense for the webauthn module to expose the methods explicitly and skip the noqa: F401.

error: Module "webauthn" does not explicitly export attribute "generate_authentication_options"; implicit reexport disabled
...

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2023

CLA assistant check
All committers have signed the CLA.

grcspace311

This comment was marked as spam.

@MasterKale
Copy link
Collaborator

@warlo Thank you for your submission, this is great! This library is only the second Python library I've ever published to PyPI and so tricks like this one are still new to me. And this all makes mypy happy?

Things have been busy lately or I'd have responded earlier. I'll take a closer look soon and review it all properly.

@warlo
Copy link
Contributor Author

warlo commented Feb 14, 2023

No probs! __all__ defines what the module exports, and also makes it support from webauthn import *.
Similar case: konradhalas/dacite#133

For mypy's case I did not notice anything else, so should be good afaics 👍

@MasterKale MasterKale merged commit 5b9f394 into duo-labs:master Feb 17, 2023
@MasterKale
Copy link
Collaborator

@warlo Thank you for the contribution! This is going out to PyPI as we speak as webauthn==1.7.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants