Skip to content

Commit

Permalink
Update patch set 1
Browse files Browse the repository at this point in the history
Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > P.S. Mark, what is the importance?
> > 
> > The same as it is here: https://chromium.googlesource.com/external/gyp/+/e8850240a433259052705fb8c56e51795b7dc9c3/pylib/gyp/MSVSVersion.py#107. Not doing this for 2017 is effectively a regression from what we did for 2013 and 2015.
> > 
> > Why wouldn’t you choose the native 64-bit executable, larger address space and all, if it’s available to you? The fact that you’re targeting 32-bit should have absolutely no bearing on the decision.
> 
> So there's no "real" importance

I wouldn’t say that at all. We have, in the past, found that the larger address space available to a 64-bit process meant the difference between being able to build a large chunk of code under heavy optimization and not.

Patch-set: 1
Reviewer: Gerrit User 1174099 <1174099@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
  • Loading branch information
Gerrit User 1174099 authored and Gerrit Code Review committed Apr 25, 2017
1 parent b63fbce commit cb9addb
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit cb9addb

Please sign in to comment.