improving PR #11 #12
Merged
improving PR #11 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a few Rust versions now, sealed traits no longer need to (ab)use public-in-private tricks, since private supertraits are allowed. With a unsafe fn new_scope(...) -> impl Scope<...>, the type Wrapper no longer needs to be public either.
…sed-in expressions. Especially unsafe is important, as the macro would otherwise be unsound, allowing unsafe code in e.g. a scop!() without explicit usage of `unsafe` from the user.
…tion
I believe rustfmt support is important enough that we should encourage this encourage
this style, and even force the inner braces to help with that. Also, this makes
the macro just take a simple $b:block, which makes the rendered docs
slightly more clear what is expected syntactically, compared to
the status quo of {$($t:tt)*}.
|
(if you merge this, consider using rebasing, or even better using fast-forward, so this becomes part of #11 cleanly without a merge commit) |
…ases involving lifetimes.
For example if we have something like
```rs
fn try_zip_files<'scope, 'a: 'scope, R: Read + Seek + 'scope>(
mut archive: ZipArchive<R>,
s: &'a str,
) -> impl nolife::Scope<Family = ZipReaderFamily, Output = ZipResult<nolife::Never>> + 'scope {
scope!({
/*use s */ s;
// ...
}
}
```
this code fails before this commit.
(The general pattern is to add a `+ 'scope` lifetime and then
add `…: 'scope` bounds for all captured lifetimes and type parameters.)
This still leaves adding an actual test case for such a use case (and documentation for it) as TODO.
|
Thanks, these look good. I will take the time to merge it later, hopefully by tonight. One concern I have with #11 (not your changes) is that it is now difficult to fix all generic parameters of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.