This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Circuit trait impl for BlindBid circuit #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2020 19:01
This is needed because the `Circuit` trait was released on this version.
CPerezz
added
area:cryptography
src/proof.rs
Outdated
| &mut self, | ||
| composer: &mut StandardComposer, | ||
| ) -> Result<Vec<PublicInput>, Error> { | ||
| // Instanciate PI vector. |
src/proof.rs
Outdated
| bid.stealth_address.R().into(), | ||
| ), | ||
| ); | ||
| let bid_elegibility_ts = |
| pi.push(PublicInput::BlsScalar( | ||
| -branch.root, | ||
| composer.circuit_size(), | ||
| )); |
There was a problem hiding this comment.
Is this supposed to be a double closure?
There was a problem hiding this comment.
WDYM by double closure? There's no closure in here. Is just pushing an enum to a vec.
There was a problem hiding this comment.
The format on my screen was squashed and messed up, so it placed the braces in the wrong place.
|
|
||
| // 6. 0 < value <= 2^64 range check | ||
| // v < 2^64 | ||
| composer.range_gate(bid_value.var, 64usize); |
There was a problem hiding this comment.
Isn't the range function naturally taking in a usize? If so, is the input of it here redundant?
src/proof.rs
Outdated
| let (ck, _) = pub_params.trim(1 << 16)?; | ||
| // Generate & save `ProverKey` with some random values. | ||
| let mut prover = Prover::new(b"TestCircuit"); | ||
| // Set size & Pi builder |
vlopes11
approved these changes
Sep 29, 2020
This was referenced Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65