Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'need_bootstrappers' to have dinamically threshold #135

Closed
herr-seppia opened this issue Mar 7, 2024 · 0 comments · Fixed by #143
Closed

Update 'need_bootstrappers' to have dinamically threshold #135

herr-seppia opened this issue Mar 7, 2024 · 0 comments · Fixed by #143
Labels

Comments

@herr-seppia
Copy link
Member

herr-seppia commented Mar 7, 2024

Summary

This issue aims to enhance the 'need_bootstrappers' function by updating it to use 'alive_nodes' instead of 'closest_peers'. The current implementation introduces a hardcoded threshold value of 10 during the bootstrapping procedure, which deviates from the specified recommendation of 3 in the protocol specification.

Possible solution design or implementation

To address this issue, the 'need_bootstrappers' function should be modified to utilize 'alive_nodes' for determining the minimum number of nodes during the bootstrapping phase. This change ensures that the threshold is no longer hardcoded, making it configurable by the library user.

Additional context

By allowing users to set their own threshold, we empower them to tailor the bootstrapping procedure to their specific needs.
Additionally, the contact rate should be customizable too (now is 30secs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant