Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'reserved' field compatibility #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 'reserved' field compatibility #144

wants to merge 1 commit into from
+38 −16

Conversation

herr-seppia
Copy link
Member

Resolves #137

@autholykos autholykos assigned autholykos and unassigned autholykos Apr 3, 2024
@autholykos autholykos self-requested a review April 3, 2024 07:30
autholykos
autholykos reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that making a reserved field dynamic is an anti-pattern. If the intention is to provide forward compatibility in the form of protocol extension, this should be properly introduced in the protocol without abusing the reserved field

@autholykos
Copy link
Member

On a second thought, the impact of a dynamic reserved field is minimal if considering that it might be abused for other uses anyway.

@autholykos autholykos self-requested a review April 4, 2024 13:39
autholykos
autholykos approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia force-pushed the fix-reserved branch 2 times, most recently from b3ae3c1 to dedc023 Compare April 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autholykos autholykos autholykos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review 'reserved' field in header.rs for improved compatibility
2 participants
@herr-seppia @autholykos