Skip to content

Commit

Permalink
core: Add comment on ZeroizeOnDrop
Browse files Browse the repository at this point in the history
Resolves #244
  • Loading branch information
moCello committed Sep 18, 2024
1 parent 8d70fac commit de5e503
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions core/src/keys/secret.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ use subtle::{Choice, ConstantTimeEq};
///
/// sk.zeroize();
/// ```
///
/// # Note
/// Implementing `ZeroizeOnDrop` seems like an excellent way to lift the burden
/// of manually zeroizing after use off the user, but unfortunately it doesn't
/// delete the memory reliably. See #244
#[derive(Clone, Eq, Debug, Zeroize)]
#[cfg_attr(
feature = "rkyv-impl",
Expand Down

0 comments on commit de5e503

Please sign in to comment.