Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and use the AES cipher instead of PoseidonCipher #152

Closed
xevisalle opened this issue Apr 5, 2024 · 0 comments · Fixed by #151
Closed

Implement and use the AES cipher instead of PoseidonCipher #152

xevisalle opened this issue Apr 5, 2024 · 0 comments · Fixed by #151
Assignees
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Milestone

Comments

@xevisalle
Copy link
Member

xevisalle commented Apr 5, 2024

Epic

Summary

Atm we were using PoseidonCipher to encrypt the value / blinder in the notes. While it was a requirement for in-circuit encryption, this is not the case anymore as we got rid of the send to contract obfuscated approach. We can now use a faster solution instead, like AES. In particular, we've chosen AES-GCM (https://crates.io/crates/aes-gcm), given that:

  • it's efficient
  • it's approved by NIST
  • the crate has been audited
  • the crate is widely used
@xevisalle xevisalle linked a pull request Apr 5, 2024 that will close this issue
@HDauven HDauven added the type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) label Apr 10, 2024
@HDauven HDauven added this to the Mainnet milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants