Add AES cipher module #151
Conversation
xevisalle
requested review from
moCello,
ureeves,
ZER0,
marta-belles and
herr-seppia
I will think about the errors... probably you are right. About the deterministic: the |
There was a problem hiding this comment.
Great work!
A few little comments and generally please try to get rid of the unwrap. Better return a Result and convert the aes-gcm error type into an phoenix-core error type so you can use the ? operator. (deleted all my previous separate comments on this to declutter the review)
And another question, is it possible to name the cipher module encryption? not sure what is the convention here but to me encryption makes more sense
Good, I'll create the errors and use the ?. Cipher is the algorithm. Encryption is commonly used for the same purpose but AFAIK is a bit more generic. I used it in our context to refer to the pair nonce + ciphertext. I don't have a strong opinion but |
|
Personally I have a preference for |
There was a problem hiding this comment.
Nice!
A general remark:
I would really try to avoid try_into. It makes you need to unwrap where it's not really needed.
If you generate an array that has the correct size and then copy the bytes you need, you have more control on what's happening and avoid unwrap.
src/error.rs
Outdated
| use core::fmt; | ||
| use dusk_bytes::{BadLength, Error as DuskBytesError, InvalidChar}; | ||
|
|
||
| extern crate alloc; |
There was a problem hiding this comment.
I don't think you need this anymore.
src/note.rs
Outdated
| @@ -93,14 +93,14 @@ impl Eq for Note {} | |||
| impl Note { | |||
| /// Creates a new phoenix output note | |||
| pub fn new<R: RngCore + CryptoRng>( | |||
| rng: &mut R, | |||
| mut rng: &mut R, | |||
src/note.rs
Outdated
| psk: &PublicKey, | ||
| value: u64, | ||
| blinding_factor: JubJubScalar, | ||
| ) -> Self { | ||
| let stealth_address = psk.gen_stealth_address(r); | ||
| let r = JubJubScalar::random(&mut rng); |
Resolves: #152
Summary
ciphermodule, which uses AES-GCM for encryption.ciphermodule throughout the code, removingPoseidonCipher.Messagemodule, only meant to be used along with thesend to / withdraw from contract obfuscated, whose feature will be removed too.