Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SecretKey::sk_r to generate_note_sk and StealthAddress::pk_r to note_pk #156

Closed
moCello opened this issue Apr 19, 2024 · 0 comments · Fixed by #157
Closed

Rename SecretKey::sk_r to generate_note_sk and StealthAddress::pk_r to note_pk #156

moCello opened this issue Apr 19, 2024 · 0 comments · Fixed by #157

Comments

@moCello
Copy link
Member

moCello commented Apr 19, 2024

Summary

Rename SecretKey::sk_r to generate_note_sk and StealthAddress::pk_r to note_pk to make the methods more descriptive.
moCello added a commit that referenced this issue Apr 19, 2024
@moCello
Rename sk_r and pk_r to note_..
c0b5dc9 
Resolves #156
@moCello moCello mentioned this issue Apr 19, 2024
Merged
moCello added a commit that referenced this issue Apr 19, 2024
@moCello
Rename sk_r and pk_r to note_..
d432b25 
Resolves #156
moCello added a commit that referenced this issue Apr 22, 2024
@moCello
Rename sk_r and pk_r to note_..
560b72e 
Also remove `StealthAddress::address` method since it is a duplicate of
`StealthAddress.note_pk().as_ref()`.

Resolves #156
moCello added a commit that referenced this issue Apr 22, 2024
@moCello
Rename sk_r and pk_r to note_..
e669086 
Also remove `StealthAddress::address` method since it is a duplicate of
`StealthAddress.note_pk().as_ref()`.

Resolves #156
@moCello moCello mentioned this issue Apr 24, 2024
Merged
moCello added a commit that referenced this issue Apr 30, 2024
@moCello
Add empty method for the Note
3b2efb6 
Resolves #156
@moCello moCello mentioned this issue May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename sk_r and pk_r to note_.. dusk-network/phoenix
1 participant
@moCello