Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use From trait to generate keys #138

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Use From trait to generate keys #138

merged 1 commit into from
Dec 8, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 7, 2023

Resolves #136

herr-seppia
herr-seppia approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Why did you remove the HexDebug? I liked it

@moCello
Copy link
Member Author

moCello commented Dec 7, 2023 •
edited
Loading

Since we merged the bls and jubjub curve with the upstream code, we don't derive HexDebug for scalars anymore, instead we use their Debug implementation which should give the same result as our previous HexDebug.

@moCello moCello merged commit 7606c98 into master Dec 8, 2023
5 checks passed
@moCello moCello deleted the mocello/136_from_sk branch December 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herr-seppia herr-seppia herr-seppia approved these changes

@ureeves ureeves ureeves approved these changes

@HDauven HDauven Awaiting requested review from HDauven

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement From<SecretKey> for PublicKey and ViewKey
3 participants
@moCello @ureeves @herr-seppia