Add contract deployment transaction #164
Conversation
The deployment transaction contains the metadata necessary to deploy a contract, together with its bytecode and possible constructor arguments. Resolves: #163
There was a problem hiding this comment.
Since we now have the transaction-types in the rusk contracts, wouldn't it make sense to add the Transaction there too? Ideally I would like to get rid of the mod transaction in phoenix-core all together.
Edit: I think that is part of a bigger discussion though and not strictly related to this PR.
There was a problem hiding this comment.
This LGTM
As far as I understand a Transaction can now be 3 different things:
- a normal transaction (
exec = None) - a call to a contract function (
exec = Some(call)) - a deployment of a new contract (
exec = Some(deploy))
With the changes that are coming up in phoenix, we might need to rethink much of the overall design of the contract but that's for later ;)
| bytecode, | ||
| constructor_args, | ||
| } => { | ||
| bytes.push(2); |
There was a problem hiding this comment.
Since the encodings 0,1,2 are also used below for deserialisation, could we maybe introduce some implicit constants for them? Also, case 0 would be easier to understand if it had a name.
|
Not relevant anymore |
The deployment transaction contains the metadata necessary to deploy a contract, together with its bytecode and possible constructor arguments.
Resolves: #163