Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction circuit #173

Merged
merged 2 commits into from
May 17, 2024
Merged

Add transaction circuit #173

merged 2 commits into from
May 17, 2024

Conversation

xevisalle
Copy link
Member

No description provided.

@xevisalle xevisalle requested review from moCello and ureeves May 16, 2024 14:05
@xevisalle xevisalle linked an issue May 16, 2024 that may be closed by this pull request
Merge transaction circuits into one #169
Closed
@xevisalle xevisalle changed the title Add transfer circuit Add transaction circuit May 16, 2024
moCello
moCello approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ureeves
ureeves approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I have is naming considerations, which we've discussed, and one nit on the change in the README. Otherwise LGTM. Please do squash your commits though

circuits/README.md Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
@xevisalle @moCello
Add transaction circuit
c8f681d 
Co-authored-by: Moana <moana@dusk.network>
@xevisalle xevisalle merged commit 0c72c7c into master May 17, 2024
6 checks passed
@xevisalle xevisalle deleted the circuit branch May 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

@ureeves ureeves ureeves approved these changes

@marta-belles marta-belles Awaiting requested review from marta-belles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge transaction circuits into one
3 participants
@xevisalle @moCello @ureeves