Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify fn signature for add_witness_to_circuit_description #282

Closed
CPerezz opened this issue Aug 13, 2020 · 0 comments · Fixed by #284
Closed

Modify fn signature for add_witness_to_circuit_description #282

CPerezz opened this issue Aug 13, 2020 · 0 comments · Fixed by #284
Assignees
@CPerezz
Labels
type:feature implementing a new feature

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Aug 13, 2020

@kevaundray was right and there's a method that does the exact same thing called: add_witness_to_circuit_description but it asks fora Variable and a Scalar when it could just ask for a Scalar and return the Variable. So I'll create an issue in order to address that.

Originally posted by @CPerezz in #280 (comment)
@CPerezz CPerezz self-assigned this Aug 13, 2020
@CPerezz CPerezz added API-design type:feature implementing a new feature labels Aug 13, 2020
CPerezz pushed a commit that referenced this issue Aug 13, 2020
Update add_witness_to_circuit_description fn sig
56eba68 
Previously this required to send both, a `Scalar` and
a `Variable` with the same shared value.

By modifying the function signature, this will generate
a witness `Variable` constrained to be equal to
a constant `Scalar` which is sent to the function.

Closes #282
@CPerezz CPerezz mentioned this issue Aug 13, 2020
Merged
CPerezz added a commit that referenced this issue Aug 13, 2020
@CPerezz
Update add_witness_to_circuit_description fn sig (#284)
ad1ede4 
Previously this required to send both, a `Scalar` and
a `Variable` with the same shared value.

By modifying the function signature, this will generate
a witness `Variable` constrained to be equal to
a constant `Scalar` which is sent to the function.

Closes #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
type:feature implementing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update add_witness_to_circuit_description fn sig dusk-network/plonk
1 participant
@CPerezz