Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for point equality assertion #725

Closed
moCello opened this issue Jan 24, 2023 · 0 comments · Fixed by #726
Closed

Add more tests for point equality assertion #725

moCello opened this issue Jan 24, 2023 · 0 comments · Fixed by #726

Comments

@moCello
Copy link
Member

moCello commented Jan 24, 2023

Describe what you want implemented
Add tests for assert_equal_point method of the composer:

  • sanity test
  • fails when the points are not equal
  • fails when only one of the coordinates are not equal

Describe "Why" this is needed
We need to increase our tests coverage, as the issue #721 clearly showed.

Describe alternatives you've considered
N/A

Additional context
N/A
moCello added a commit that referenced this issue Jan 24, 2023
@moCello
Add tests for assert_equal_point method
1e26499 
Resolves #725
This was referenced Jan 24, 2023
Merged
Closed
moCello added a commit that referenced this issue Jan 24, 2023
@moCello
Add tests for assert_equal_point method
8690aa9 
Resolves #725
@moCello moCello mentioned this issue Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more tests for assert_equal_point dusk-network/plonk
1 participant
@moCello