Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim size as param #314

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Trim size as param #314

merged 2 commits into from
Oct 5, 2020

Conversation

CPerezz
Copy link
Contributor

@CPerezz CPerezz commented Oct 5, 2020

On the cases where we have variable-size circuits,
we need a way to use different trim_sizes for our Circuit
instance. With the previous API this was not possible.

Therefore, the method set_trim_size has been added.

On the cases where we have variable-size circuits,
we need a way to use different trim_sizes for our Circuit
instance. With the previous API this was not possible.

Therefore, the method `set_trim_size` has been added.
@CPerezz CPerezz added area:cryptography anything related to cryptographic primitives, hashing and ZKP type:feature implementing a new feature type:tech-debt the issue is a tech debt that needs fixing labels Oct 5, 2020
@CPerezz CPerezz requested review from vlopes11 and jules October 5, 2020 17:06
Copy link
Contributor

@jules jules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPerezz CPerezz merged commit 228d0ea into master Oct 5, 2020
@CPerezz CPerezz deleted the trim_size_as_param branch October 5, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP type:feature implementing a new feature type:tech-debt the issue is a tech debt that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants