Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl From trait for Commitment #492

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Impl From trait for Commitment #492

merged 3 commits into from
Apr 13, 2021

Conversation

oriolval
Copy link
Contributor

@oriolval oriolval commented Apr 8, 2021 •
edited by CPerezz
Loading

Implement From G1Affine and G1Projective for Commitment.
Resolves: #433

@CPerezz CPerezz self-requested a review April 12, 2021 14:46
@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Apr 12, 2021
@CPerezz CPerezz self-assigned this Apr 12, 2021
CPerezz
CPerezz suggested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@CPerezz CPerezz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really nice. I would like you to also add in the CHANGELOG.md inside of the Changed section the changes introduced by this PR referencing the issue this addresses following the same format of the entire doc.

Once is done, this will get merged.

@oriolval
Implement From for Commitment
a521e79 
Implement From G1Affine and G1Projective for Commitment.
Resolves: dusk-network#433
@oriolval
Update CHANGELOG.md
7ab7ed8
@oriolval oriolval changed the base branch from master to release-0.8 April 13, 2021 21:51
@oriolval oriolval changed the title From trait Impl From trait for Commitment Apr 13, 2021
@CPerezz CPerezz self-requested a review April 13, 2021 21:54
CPerezz
CPerezz approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @oriolval !!

@CPerezz CPerezz merged commit ca5b90a into dusk-network:release-0.8 Apr 13, 2021
@oriolval oriolval deleted the from_trait branch April 13, 2021 21:55
CPerezz pushed a commit that referenced this pull request Apr 14, 2021
Add back @oriolval From impl from #492
ea9ba5c
@CPerezz CPerezz mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerezz CPerezz CPerezz approved these changes

Assignees

@CPerezz CPerezz

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impl From trait for Commitment conversions
2 participants
@oriolval @CPerezz