Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size method to Circuit trait #768

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add size method to Circuit trait #768

merged 2 commits into from
Oct 5, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Oct 5, 2023

This change also removes the need to preallocate the circuit builder which in turn removes the need to pass the public parameters when compressing a circuit.

Resolves #767

This change also removes the need to preallocate the circuit builder
which in turn removes the need to pass the public parameters when
compressing a circuit.
@moCello moCello requested a review from ureeves October 5, 2023 13:02
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #768 (577738b) into master (bcb31de) will decrease coverage by 0.21%.
The diff coverage is 70.00%.

❗ Current head 577738b differs from pull request most recent head 0e0b3d4. Consider uploading reports for the commit 0e0b3d4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   85.07%   84.86%   -0.21%     
==========================================
  Files          57       57              
  Lines        4327     4327              
==========================================
- Hits         3681     3672       -9     
- Misses        646      655       +9     
Files Coverage Δ
src/composer/builder.rs 80.00% <100.00%> (ø)
tests/composer.rs 95.91% <ø> (ø)
src/composer/compiler.rs 98.42% <75.00%> (+0.47%) ⬆️
src/composer/compiler/compress.rs 87.82% <87.50%> (-0.08%) ⬇️
src/composer.rs 91.00% <77.77%> (-0.03%) ⬇️
src/debugger.rs 67.41% <33.33%> (-5.85%) ⬇️
src/runtime.rs 18.75% <0.00%> (-19.72%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb31de...0e0b3d4. Read the comment docs.

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit e03f199 into master Oct 5, 2023
5 checks passed
@moCello moCello deleted the mocello/size branch October 5, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add size method to Circuit trait
2 participants