Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #769

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update dependencies #769

merged 1 commit into from
Oct 11, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Oct 11, 2023

  • dusk-bls12_381 -> v0.12
  • dusk-jubjub -> v0.13

Notable changes in the new versions:

  • jubjub point getters renamed
  • BlsScalar::random changed slightly

- `dusk-bls12_381` -> v0.12
- `dusk-jubjub` -> v0.13

Notable changes in the new versions:
- jubjub point getters renamed
- BlsScalar::random changed slightly
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #769 (ad3ad6f) into master (e03f199) will decrease coverage by 0.01%.
The diff coverage is 98.62%.

❗ Current head ad3ad6f differs from pull request most recent head 4d3aec5. Consider uploading reports for the commit 4d3aec5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   84.86%   84.86%   -0.01%     
==========================================
  Files          57       57              
  Lines        4327     4333       +6     
==========================================
+ Hits         3672     3677       +5     
- Misses        655      656       +1     
Files Coverage Δ
src/bit_iterator.rs 75.00% <ø> (+4.41%) ⬆️
src/commitment_scheme/kzg10/srs.rs 81.33% <ø> (-1.34%) ⬇️
src/composer/prover.rs 95.75% <ø> (ø)
src/fft/polynomial.rs 42.85% <ø> (-0.72%) ⬇️
src/permutation.rs 92.64% <ø> (ø)
src/proof_system/proof.rs 96.61% <ø> (ø)
src/proof_system/widget.rs 88.95% <ø> (ø)
src/util.rs 100.00% <100.00%> (+5.00%) ⬆️
tests/append_gate.rs 93.10% <100.00%> (ø)
tests/assert_point.rs 83.05% <100.00%> (ø)
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03f199...4d3aec5. Read the comment docs.

@moCello moCello requested a review from miloszm October 11, 2023 14:43
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. LGTM

@moCello moCello merged commit 0e4b7c6 into master Oct 11, 2023
5 checks passed
@moCello moCello deleted the update_dependencies branch October 11, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants