Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InvalidCircuitSize error message #793

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 12, 2023

Resolves #792

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1f655c2) 85.65% compared to head (a7270b0) 85.63%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
- Coverage   85.65%   85.63%   -0.02%     
==========================================
  Files          57       57              
  Lines        4119     4128       +9     
==========================================
+ Hits         3528     3535       +7     
- Misses        591      593       +2     
Files Coverage Δ
src/composer.rs 90.93% <100.00%> (+0.36%) ⬆️
src/error.rs 8.33% <33.33%> (+8.33%) ⬆️
tests/error_size.rs 72.00% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f655c2...a7270b0. Read the comment docs.

@moCello moCello force-pushed the mocello/size_error branch 2 times, most recently from 0c391fd to 48f66ce Compare December 20, 2023 11:58
@moCello moCello marked this pull request as ready for review December 20, 2023 14:11
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 97240ce into master Dec 20, 2023
10 checks passed
@moCello moCello deleted the mocello/size_error branch December 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when attempting to create a proof for a circuit with the wrong size
2 participants