Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure modules internally #806

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Restructure modules internally #806

merged 1 commit into from
Dec 22, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 21, 2023

Resolves #805

- Move `compiler` module to root
- Move prover and verifier modules under compiler
- Move compress module under composer
- Move constraint_system module under composer
- Move permutation module under composer
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a18dd1) 85.66% compared to head (9f6b758) 85.74%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   85.66%   85.74%   +0.08%     
==========================================
  Files          57       57              
  Lines        4095     4091       -4     
==========================================
  Hits         3508     3508              
+ Misses        587      583       -4     
Files Coverage Δ
src/compiler.rs 99.44% <100.00%> (ø)
src/compiler/prover.rs 95.54% <ø> (ø)
src/compiler/verifier.rs 86.00% <ø> (ø)
src/composer.rs 95.66% <100.00%> (ø)
src/composer/compress.rs 85.82% <ø> (ø)
src/composer/compress/hades.rs 81.81% <ø> (ø)
src/composer/constraint_system/constraint.rs 61.01% <ø> (ø)
src/composer/constraint_system/ecc.rs 66.66% <ø> (ø)
src/composer/constraint_system/witness.rs 66.66% <ø> (ø)
src/composer/gate.rs 0.00% <ø> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a18dd1...9f6b758. Read the comment docs.

@moCello moCello requested a review from HDauven December 22, 2023 12:03
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit db46f87 into master Dec 22, 2023
10 checks passed
@moCello moCello deleted the mocello/805_restructure branch December 22, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure modules
2 participants