Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API for circuit compression #807

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 21, 2023

Resolves #804

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (db46f87) 85.74% compared to head (4969419) 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   85.74%   85.71%   -0.04%     
==========================================
  Files          57       57              
  Lines        4091     4095       +4     
==========================================
+ Hits         3508     3510       +2     
- Misses        583      585       +2     
Files Coverage Δ
src/compiler.rs 99.44% <100.00%> (ø)
src/composer/compress.rs 85.95% <100.00%> (+0.12%) ⬆️
tests/composer.rs 96.49% <100.00%> (+0.06%) ⬆️
src/composer/circuit.rs 45.45% <83.33%> (+45.45%) ⬆️
src/composer.rs 95.04% <33.33%> (-0.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46f87...4969419. Read the comment docs.

@moCello moCello force-pushed the mocello/804_compress branch 2 times, most recently from 3d5c4de to ab6ce8d Compare December 21, 2023 15:21
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 780bbf9 into master Jan 2, 2024
10 checks passed
@moCello moCello deleted the mocello/804_compress branch January 2, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve API for circuit (de-)compression
2 participants