Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hades constants from 960 to 335 #814

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Feb 13, 2024

Resolves #813

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c053660) 85.71% compared to head (bd762a1) 85.34%.

❗ Current head bd762a1 differs from pull request most recent head cf2dcf3. Consider uploading reports for the commit cf2dcf3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   85.71%   85.34%   -0.37%     
==========================================
  Files          57       57              
  Lines        4095     3686     -409     
==========================================
- Hits         3510     3146     -364     
+ Misses        585      540      -45     
Files Coverage Δ
src/composer/compress/hades.rs 81.81% <ø> (ø)

... and 51 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c053660...cf2dcf3. Read the comment docs.

Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might make sense to mention this change in the changelog though.

@moCello moCello merged commit 7505e9a into master Feb 13, 2024
9 checks passed
@moCello moCello deleted the mocello/813_hades_constants branch February 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce hades constants count
2 participants