Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-server versioning capabilities #717

Closed
t00ts opened this issue May 12, 2022 · 0 comments · Fixed by #718
Closed

Add client-server versioning capabilities #717

t00ts opened this issue May 12, 2022 · 0 comments · Fixed by #718
Assignees

Comments

@t00ts
Copy link
Contributor

t00ts commented May 12, 2022

Describe what you want implemented

  1. Decorate gRPC response headers with running Rusk version (incl. errors and unimplemented methods)
  2. Introduce ability to match client versions with semver and return custom status.

Describe "Why" this is needed
To decouple Rusk releases from clients such as the Chain component or the Wallet CLI.

Describe alternatives you've considered
Using the schema version, but we concluded it was a completely different thing (thus not being discarded either).

Additional context
N/A

@t00ts t00ts self-assigned this May 12, 2022
t00ts added a commit that referenced this issue May 16, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 17, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
t00ts added a commit that referenced this issue May 18, 2022
- check version compatibility on requests
- send version on all responses

Resolves #717
@ZER0 ZER0 closed this as completed in #718 May 20, 2022
moCello added a commit that referenced this issue Jul 6, 2023
moCello added a commit that referenced this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant