Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #242

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Small improvements #242

merged 4 commits into from
Mar 26, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Mar 22, 2024 •
edited
Loading

  • Change rusk-wallet to wait for tx to be included
  • Improve tx history performance
  • Add support for WALLET_MAX_ADDR=1

HDauven
HDauven approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia
Copy link
Member Author

Relating to #243

Testing with 400txs

Before:
cargo r --release -- -p history 2.20s user 0.79s system 4% cpu 1:08.78 total

After
cargo r --release -- -p history 1.59s user 0.52s system 6% cpu 34.398 total

@herr-seppia
bin: improve tx history performance
f5a1c31 
- Remove the additional call for gas_spent
- Remove the tx_id computation

Resolves #243
@herr-seppia
Update CHANGELOG.md
5860a92
This was linked to issues Mar 26, 2024
Improve transaction history performance #243
Closed
Support WALLET_MAX_ADDR lower than 5 #244
Closed
@herr-seppia herr-seppia changed the title Change rusk-wallet to wait for tx to be included Small improvements Mar 26, 2024
@herr-seppia herr-seppia merged commit bb97c9e into main Mar 26, 2024
6 checks passed
@herr-seppia herr-seppia deleted the single_address branch March 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support WALLET_MAX_ADDR lower than 5 Improve transaction history performance
2 participants
@herr-seppia @HDauven