Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move header error out of enum #3

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

fontanierh
Copy link

Remove the Invalid Response Header out of the enum

@fontanierh fontanierh requested a review from spolu June 3, 2024 09:15
Copy link

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

why std::result::Result given the fact that the file has pub type Result<T> = std::result::Result<T, Error>; ?

I would move it next to ResponseWrapper but otherwise LGTM

@fontanierh
Copy link
Author

why std::result::Result given the fact that the file has pub type Result = std::result::Result<T, Error>; ?

Precisely because we're not returning Error, which is the Enum defined in this file that has the SSE loop errors.

@fontanierh
Copy link
Author

I would move it next to ResponseWrapper but otherwise LGTM

Can def do that 👍

@spolu
Copy link

spolu commented Jun 3, 2024

why std::result::Result given the fact that the file has pub type Result = std::result::Result<T, Error>; ?

Precisely because we're not returning Error, which is the Enum defined in this file that has the SSE loop errors.

Ah I see 👍

@fontanierh fontanierh merged commit d34896e into main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants