ci: Use GitHub App token to run release-please job
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Build Bot✅ Successful build ⬇️ Download: notero-0.5.17-469 |
dvanoni
force-pushed
the
github-app-token-release-action
branch
from
d4d42e2
to
c2ac319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions has a limitation where a workflow run using the default
GITHUB_TOKENwill not trigger further workflow runs. This was impacting therelease-pleasejob because the release PRs created by it would not trigger thebuildjob. This unfortunately led me to disable the build check for PRs tomain, which was not ideal.Educated by documentation for the create-pull-request action, I found a workaround for this using GitHub Apps and created the Notero Bot app for this purpose. The
release-pleasejob now uses the create-github-app-token action to create a token on behalf of Notero Bot and use that for creating the release PRs. This should hopefully result in workflows being run for these PRs, which will then allow us to re-enable the PR checks.This PR also replaces
google-github-actions/release-please-actionwithgoogleapis/release-please-actionsince it was recently moved.