Visitor pattern for Expression #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccept + to all subclasses
…nsformed expression (still wip)
… the parsed expression (otherwise vistor-based transformations lose the initial grouping)
…r implementations
…xpressions (and, or, implies, not)
…gicalOperationExpressions
…onExpressions containing a DefOperation
…turned expressions are new objects
|
Thankyou @chrstphlbr for PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the Visitor pattern (
org.dvare.expression.ExpressionVisitor) for Expression (and all its subclasses) to support, e.g., transformations of expressions in a neat way.I also added a base implementation
org.dvare.expression.BaseExpressionVisitorthat traverses the expression tree and returns copies of each node, and tests to ensure the correct behavior.In addition, I changed
org.dvare.expression.operation.utility.LeftPriorityandorg.dvare.expression.operation.utility.RightPriorityto remain in the parsed expression (whenLeftpriority::parseis called), to retain the information of groupings after a visitor pass.I further implemented the distinct function in
org.dvare.expression.operation.list.DistinctOperation, added tests for it, and implemented the corresponding visitor methods.I added support for boolean literals and variables in logical operator expressions and if-then-else conditionals.
Let me know if there is anything to adapt.
Christoph