Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Violated assertions should be displayed #157

Open
dvmorozov opened this issue Feb 18, 2020 · 1 comment
Open

Violated assertions should be displayed #157

dvmorozov opened this issue Feb 18, 2020 · 1 comment
Assignees
@dvmorozov
Labels
enhancement
Milestone
1.2.x.x

Comments

@dvmorozov
Copy link
Owner

dvmorozov commented Feb 18, 2020 •
edited
Loading

Solution

  1. Review and add new assertions where necessary. ✔️
  2. Exceptions replace by assertions where possible. ✔️
  3. Log assertions and exceptions. ✔️
  4. Assertions from additional threads should be caught and displayed.

Asserts generate EAssertionFailed exception, it could be intercepted by AssertErrorProc.

References

https://www.freepascal.org/docs-html/rtl/system/assert.html

Related

#90
@dvmorozov dvmorozov added this to the 1.1.x.x milestone Feb 18, 2020
@dvmorozov dvmorozov self-assigned this Feb 18, 2020
@dvmorozov dvmorozov mentioned this issue Feb 18, 2020
Open
@dvmorozov
Copy link
Owner Author

Assertions are displayed.

dvmorozov added a commit that referenced this issue May 5, 2020
@dvmorozov
New assertions added.
c4a2d80 
#157
dvmorozov added a commit that referenced this issue May 6, 2020
@dvmorozov
New assertions added.
e0db187 
#157
dvmorozov added a commit that referenced this issue May 6, 2020
@dvmorozov
New assertions added.
4a1b874 
#157
dvmorozov added a commit that referenced this issue May 8, 2020
@dvmorozov
New assertions added. Codestyling corrected.
c347c16 
#157
dvmorozov added a commit that referenced this issue May 8, 2020
@dvmorozov
New assertions added. Codestyling corrected.
ce99c59 
#157
dvmorozov added a commit that referenced this issue May 9, 2020
@dvmorozov
Exceptions replaced by assertions. Codestyling corrected.
9b8bf1b 
#157
@dvmorozov dvmorozov mentioned this issue May 9, 2020
Merged
@dvmorozov dvmorozov reopened this May 18, 2020
@dvmorozov dvmorozov modified the milestones: 1.1.x.x, 1.2.x.x May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvmorozov dvmorozov

Labels
enhancement
Projects
None yet
Milestone
1.2.x.x
Development

No branches or pull requests
1 participant
@dvmorozov