Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cb2-11778): updated mysql2 to the latest version #79

Closed
wants to merge 3 commits into from

Conversation

kcarr-bjss
Copy link
Contributor

@kcarr-bjss kcarr-bjss commented Apr 18, 2024

Version bump for mysql2

Updated mysql2 to the latest version to bring in a fix to a critical security issue
CB2-11778

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

@cb-cs
Copy link
Contributor

cb-cs commented Apr 30, 2024

Appreciate it is not your change, but is there any chance you can rectify the empty space before .idea/** on line 48 of the .gitIgnore file please?

# Idea specific hidden files
 .idea/**

@cb-cs
Copy link
Contributor

cb-cs commented Apr 30, 2024

I think this may need a rebase, the PR is not showing some of the changes that were merged into develop 5 days ago: https://github.com/dvsa/cvs-svc-enquiry/pull/81/files

Daniel-Searle
Daniel-Searle previously approved these changes May 1, 2024
@Daniel-Searle
Copy link
Contributor

Going to close this PR due to the base branch being incorrect, should be feature not chore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants