Support numpy>=1.17.3 #1204
Merged
Support numpy>=1.17.3 #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
force-pushed
the
loosen-numpy-requirements
branch
from
fe01f18 to
d94ae63
Compare
This makes it easier for packages that depend on dimod to use oldest-supported-numpy.
arcondello
force-pushed
the
loosen-numpy-requirements
branch
from
d94ae63 to
b43b269
Compare
randomir
approved these changes
Jun 14, 2022
| 'numpy>=1.20.0,<2.0.0', | ||
| # this is the oldest supported NumPy on Python 3.8, we cannot | ||
| # support the oldest for 3.7, 1.14.5 | ||
| 'numpy>=1.17.3,<2.0.0', |
There was a problem hiding this comment.
I also think we should lift the 2.0 upper bound, but we can discuss that and/or do it in a separate PR.
There was a problem hiding this comment.
Agree it's a bit pointless, we should probably either lift it altogether or tighten it down to 1.n+2.0. But yeah, followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for packages that depend on dimod to use
oldest-supported-numpy.The issue is when a package specifies say
dimod==0.11.0,oldest-supported-numpyin their pyproject.toml, the pip install fails because dimod requiresnumpy>=1.20.0at runtime.E.g. https://app.circleci.com/pipelines/github/dwavesystems/dwave-preprocessing/83/workflows/1bd72543-e11d-463d-a56e-5cdcad38f3c9/jobs/2368
So we loosen the range as much as possible. Unfortunately, the oldest supported numpy for Python 3.7 (1.14.5) is missing some pretty key stuff, like
default_rng. So it's not really practical to support it. That means that dwave-preprocessing will need to do something likein its
pyproject.toml. At least until we can drop Python 3.7 on June 27 2023.See also dwavesystems/dwave-ocean-sdk#208