Update #51

Danwhy · 2019-02-28T16:38:17Z

Adds update and execute_ddl functions for Ecto Adapter

SimonLab

👍

RobStallion

Looks good to me 👍
Nice changes to the readme
I think it might be worth updating the @impl true to the behaviours that they adopting but it is in no way a blocker.

Danwhy added 8 commits February 18, 2019 11:45

adds create execute_ddl function clause, #44

403bb1a

adds execute_ddl alter function clause, #44

8be05cb

adds execute_ddl create index function clause, #44

ae010d8

accounts for schema_migration table in create clause, #44

54187b8

adds all required colmns, only if they are missing, #44

c0dadca

adds tests for migrations, #44

85aa257

adds update functionality, #46

7735134

merges with insert

19f0529

Danwhy changed the base branch from master to adapter February 28, 2019 16:42

merges update with adapter branch

9497ed2

Danwhy mentioned this pull request Mar 12, 2019

Execute ddl #49

Closed

adds documentation

db5378c

Danwhy force-pushed the update branch from a34a093 to db5378c Compare March 12, 2019 16:06

Danwhy marked this pull request as ready for review March 12, 2019 16:11

Merge branch 'adapter' into update

052bd7e

Danwhy assigned SimonLab and RobStallion Mar 12, 2019

SimonLab approved these changes Mar 13, 2019

View reviewed changes

SimonLab removed their assignment Mar 13, 2019

RobStallion approved these changes Mar 13, 2019

View reviewed changes

RobStallion merged commit e0e08be into adapter Mar 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update #51

Update #51

Danwhy commented Feb 28, 2019 •

edited

Loading

SimonLab left a comment

RobStallion left a comment

Update #51

Update #51

Conversation

Danwhy commented Feb 28, 2019 • edited Loading

SimonLab left a comment

Choose a reason for hiding this comment

RobStallion left a comment

Choose a reason for hiding this comment

Danwhy commented Feb 28, 2019 •

edited

Loading