-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract client_id from HTTP referer #55
Labels
enhancement
New feature or enhancement of existing functionality
priority-2
Second highest priority, should be worked on as soon as the Priority-1 issues are finished
T4h
Time Estimate 4 Hours
technical
A technical issue that requires understanding of the code, infrastructure or dependencies
Comments
nelsonic
added
enhancement
New feature or enhancement of existing functionality
priority-2
Second highest priority, should be worked on as soon as the Priority-1 issues are finished
T4h
Time Estimate 4 Hours
technical
A technical issue that requires understanding of the code, infrastructure or dependencies
labels
Apr 28, 2020
4 tasks
nelsonic
added a commit
that referenced
this issue
Apr 28, 2020
nelsonic
added a commit
that referenced
this issue
Apr 28, 2020
nelsonic
added a commit
that referenced
this issue
Apr 28, 2020
nelsonic
added a commit
that referenced
this issue
Apr 28, 2020
nelsonic
added a commit
that referenced
this issue
Apr 28, 2020
nelsonic
added a commit
that referenced
this issue
Apr 29, 2020
nelsonic
added a commit
that referenced
this issue
Apr 29, 2020
nelsonic
added a commit
that referenced
this issue
Apr 29, 2020
1 task
This is working. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or enhancement of existing functionality
priority-2
Second highest priority, should be worked on as soon as the Priority-1 issues are finished
T4h
Time Estimate 4 Hours
technical
A technical issue that requires understanding of the code, infrastructure or dependencies
auth_plug
sends theclient_id
to theauth_url
when no valid JWT is found: lib/auth_plug.ex#L167We need to verify the
client_id
(decode_decrypt/1
followed by lookup inapikeys
)and if the
client_id
is valid, use theclient_secret
to sign the JWT on successful authentication.Todo
client_id
from the HTTPreferer
client_id
is valid before displaying the "login buttons" pageclient_id
not valid, return a friendly Error:401: AUTH_API_KEY not valid
client_id
in thestate
prop that gets sent to GitHub/GoogleI checked and it's RFC3986 compliant to have multiple question marks in a URL Query:
https://stackoverflow.com/questions/2924160/is-it-valid-more-than-one-question-mark-in-a-url
client_id
from thestate
(returned by Auth Provider)decode_decrypt/1
)client_id
inapikeys
client_secret
to sign JWTWith the completion of this issue Auth dwyl/app#268 will be fully functional!
Let's get it done!
The text was updated successfully, but these errors were encountered: