Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 302 (Temporary) Redirect instead of 301 (Permanent) #12

Closed
2 tasks done
nelsonic opened this issue Apr 24, 2020 · 1 comment
Closed
2 tasks done

Use 302 (Temporary) Redirect instead of 301 (Permanent) #12

nelsonic opened this issue Apr 24, 2020 · 1 comment

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 24, 2020

At present we have a 301 status code when auth gets redirected:

status = 301

We actually want a 302 so the browser does not think the auth page is the new /profile page. 💭

This is a quick/easy fix.

  • Update lib/auth_plug.ex#L141 to 302
  • Update all tests that assert 301 to 302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant