Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect (Referer) Should be a Fully Qualified URL #7

Closed
1 task done
nelsonic opened this issue Apr 22, 2020 · 1 comment
Closed
1 task done

Redirect (Referer) Should be a Fully Qualified URL #7

nelsonic opened this issue Apr 22, 2020 · 1 comment
Assignees
@nelsonic
Labels
chore enhancement technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 22, 2020 •
edited
Loading

At present I am redirecting from localhost:4000/admin to the Heroku Demo app:
image

But once the Auth is successful, the redirect does not work because I'm sending a relative url.
It should be an absolute URL so that we can have our auth app on a separate subdomain.

Todo

  • ensure that referer is a fully qualified URL e.g: https://dwyl.com/admin not /admin
nelsonic added a commit that referenced this issue Apr 22, 2020
@nelsonic
create Helpers.get_baseurl_from_conn/1 for #7
5d2defa
nelsonic added a commit that referenced this issue Apr 22, 2020
@nelsonic
bump version to 0.3.0 using fully qualified URL #7
d19adba
nelsonic added a commit that referenced this issue Apr 22, 2020
@nelsonic
remember to export the lib/helpers.ex in package() files list #7
77def14
nelsonic added a commit to dwyl/auth that referenced this issue Apr 22, 2020
@nelsonic
URI.encode referer in get_referer/1 for dwyl/auth_plug#7
d9802cb
@nelsonic
Copy link
Member Author

Redirect back to localhost:
image

image

@nelsonic nelsonic self-assigned this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore enhancement technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic