displays changeset from assigns correctly #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
@Danwhy code looks good. 👍
Please force yourself to write a "Docs" update for every code change.
It will lead to a much better re-useable module/package and it's the standard you want to set for your own "junior" devs as you "level up" to a "Senior Engineer".
If you're ever in any doubt, over-document to preempt the questions people will have.
See: https://www.npmjs.com/package/hapi-auth-jwt2
Thanks for your diligence on this! ✨
You're awesome! 🦄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the correct changeset for
custom_render_autoformwhen it's passed in (as it always did forrender_autoform)