Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update to Node.js v20 #85 #92

Merged
merged 29 commits into from
Feb 4, 2024
Merged

PR: Update to Node.js v20 #85 #92

merged 29 commits into from
Feb 4, 2024

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 23, 2024

This is a much-needed update to:

  • Latest AWS SDK (v3) 🎉
  • Node.js v20 LTS

So that we can continue deploying Lambda Functions for the next couple of years.

Also:

@nelsonic
Copy link
Member Author

@nelsonic
Copy link
Member Author

Gonna have to come back to this ... debugging GitHub CI is super tedious ... 🙄

@nelsonic
Copy link
Member Author

This is such a time-suck. I would gladly pay someone else $100 to make this go away.

@nelsonic
Copy link
Member Author

Error: ENOENT: no such file or directory, scandir '/home/runner/work/_temp/fakedir'
https://github.com/dwyl/aws-lambda-deploy/actions/runs/7643215698/job/20824696029#step:6:33

image

I think this is a "New Node" throwing an error where it didn't before ... 💭

@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2024

Tests fail because function already exists:
https://github.com/dwyl/aws-lambda-deploy/actions/runs/7767852616/job/21185130555#step:6:81
image

Think I'm going to side-step this issue by only testing on one version of Node.js
Simply because running the test on 3 different instances is almost guaranteed to cause conflicts. 🙄

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@48af64b). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #92   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         7           
  Lines           ?       136           
  Branches        ?         0           
========================================
  Hits            ?       136           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2024

Tests passing. Going to try to re-enable the Node.js matrix (to test with various versions). 🤞

@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2024

Nope. Race condition when running the tests in parallel. 🙄
Might check if we can run them in series ...

@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2024

OK. I'm at the point where I'm "happy" with this. Going to bump the version and publish. 📦

Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@asntc asntc merged commit a2e1572 into main Feb 4, 2024
3 checks passed
@asntc asntc deleted the update-to-node-v20-issue-#85 branch February 4, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants