Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail #16

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Add detail #16

merged 2 commits into from
Jan 22, 2019

Conversation

nelsonic
Copy link
Member

  • Add detail to the "Why Decentralise" section of readme.

@nelsonic nelsonic added the enhancement New feature or request label Jan 22, 2019
@nelsonic nelsonic mentioned this pull request Jan 22, 2019
Open
RobStallion
RobStallion approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@RobStallion RobStallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update @nelsonic

README.md
and data can easily be "synched" when connection is re-established.

Network and hardware ***fault-tolerance*** is a ***essential***
Network and hardware ***fault-tolerance*** is ***essential***
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍

README.md
# What?
Decentralisation is not just "_philosophical_" argument,
as creative technologists we are _directly_ responsible
for the technology we create.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md

It doesn't exactly roll off the tongue.
It doesn't exactly roll off the tongue. 🙄

append-only log.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be here?

README.md
the _same_ short URL each time.

The _reason_ we can abbreviate the URL to just `gV`
is because our SHORT URL service has a _centralised_ Database/store.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for further clarifying this point 👍

SimonLab
SimonLab reviewed Jan 22, 2019
View reviewed changes
lib/cid.ex
# "ambiguous" chars are removed:
hash
hash1 = :crypto.hash(:sha512, input)
{:ok, <<_multihash_code, _length, hash2::binary>>} = Multihash.encode(:sha2_512, hash1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SimonLab
SimonLab approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nelsonic

@SimonLab SimonLab merged commit fd35e14 into master Jan 22, 2019
@SimonLab SimonLab deleted the add-detail branch January 22, 2019 11:12
iteles
iteles reviewed Jan 22, 2019
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RobStallion RobStallion mentioned this pull request Jan 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles left review comments

@RobStallion RobStallion RobStallion approved these changes

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nelsonic @iteles @SimonLab @RobStallion