Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Assign Back and Comment on PRs that do not Reference an Issue No. #140

Open
nelsonic opened this issue Jul 29, 2017 · 1 comment

Comments

@nelsonic
Copy link
Member

nelsonic commented Jul 29, 2017

Our Contributing Workflow starts with Opening an Issue:
https://github.com/dwyl/contributing/tree/cc3a47b5b4d1157e35f76c0fd5dcea6c0fad20f1#part-1-describe-your-question-the-idea-or-user-story-in-an-issue

Yet we are still getting people opening PRs ignoring the "contributing guide"... 😞
(note: I know that we need to "streamline" the contributing.md, but haven't had time recently ...)

I'm trying to be "nice" / "helpful" / "welcoming" to new contributors. e.g: dwyl/hapi-auth-jwt2#240
but the fact that the PR does not reference an issue where the feature was discussed
before the PR was opened should normally be an automatic "Close and Comment" (IMO).
If we open exceptions for "small features" we will get a torrent of them once our app(s) are "live"!

@iteles
Copy link
Member

iteles commented Jul 29, 2017

I would suggest we don't want to reject them, but certainly assign it back to the person who opened the PR and add a comment to explain. I think that would be 👌

@ghost ghost modified the milestone: Backlog Aug 9, 2017
@ghost ghost changed the title Automatically Reject a Pull Request that does Reference an Issue Number? Feature: Assign Back and Comment on PRs that do not Reference an Issue No. Aug 9, 2017
@ghost ghost added priority-3 and removed discuss question labels Aug 9, 2017
@naazy naazy self-assigned this Sep 8, 2017
@naazy naazy added T4h and removed T2h labels Sep 8, 2017
@naazy naazy added the T2h label Sep 8, 2017
naazy added a commit that referenced this issue Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants