Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awaiting reiview label and assignees #112

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Jun 20, 2017

merge after #111

see #62
If a reviewer is added to the PR then the label "awaiting-review" and the reviewer is assigned to the PR.

@codecov
Copy link

codecov bot commented Jun 20, 2017

Codecov Report

Merging #112 into master will increase coverage by 1.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   96.94%   98.08%   +1.14%     
==========================================
  Files          20       22       +2     
  Lines         131      157      +26     
==========================================
+ Hits          127      154      +27     
+ Misses          4        3       -1
Impacted Files Coverage Δ
web/controllers/rules/list_rules.ex 100% <ø> (ø) ⬆️
web/controllers/rules/pr/no_assignee.ex 100% <100%> (ø)
web/controllers/github_api/in_memory.ex 100% <100%> (ø) ⬆️
web/controllers/rules/pr/awaiting_review.ex 100% <100%> (ø)
web/models/user.ex 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cf3bb...eb424e7. Read the comment docs.

Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps look at abstracting some of the repeated code

Looks good

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab great addition. 👍
agree with @Shouston3 on abstracting. not "urgent" though, so merging this now. ✅

@nelsonic nelsonic merged commit 9f91b9d into master Jun 21, 2017
@nelsonic nelsonic deleted the add-awaiting-reiview-label branch June 21, 2017 07:53
def apply?(payload) do
(payload["action"] == "labeled")
|| (payload["action"] == "unassigned")
|| (payload["action"] == "assigned")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def apply?(payload),
  do: payload["action"] in ~w(labeled unassigned assigned)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants