-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awaiting reiview label and assignees #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 96.94% 98.08% +1.14%
==========================================
Files 20 22 +2
Lines 131 157 +26
==========================================
+ Hits 127 154 +27
+ Misses 4 3 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps look at abstracting some of the repeated code
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab great addition. 👍
agree with @Shouston3 on abstracting. not "urgent" though, so merging this now. ✅
def apply?(payload) do | ||
(payload["action"] == "labeled") | ||
|| (payload["action"] == "unassigned") | ||
|| (payload["action"] == "assigned") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def apply?(payload),
do: payload["action"] in ~w(labeled unassigned assigned)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next PR. 👍
merge after #111
see #62
If a reviewer is added to the PR then the label "awaiting-review" and the reviewer is assigned to the PR.