Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correcting wording on PR message #149 #153

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

correcting wording on PR message #149 #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4eb54ec
correcting wording on PR message #149
naazy Aug 18, 2017
193133a
addressing @shouston's comments
naazy Aug 18, 2017
e406349
hopefully upping coverage
naazy Aug 18, 2017
1f3ab1e
hopefully upping coverage again
naazy Aug 18, 2017
ee627e9
hopefully resolving CI
naazy Sep 1, 2017
e000e45
hopefully resovling CI
naazy Sep 1, 2017
878edad
hopeully resolving ci
naazy Sep 1, 2017
0175cfe
maybe resolving code cov issues
naazy Sep 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/controllers/event_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ defmodule Dwylbot.EventTestController do
%{payload: "pr_merge_conflict", event: "pull_request" },
%{payload: "pr_no_assignee", event: "pull_request" },
%{payload: "request_reviewer", event: "pull_request" },
%{payload: "pr_request_reviewer_all_reviewers_assigned", event: "pull_request" },
%{payload: "failing_test", event: "status" },
]
|> Enum.map(&(%{&1 | payload: "./test/fixtures/#{&1.payload}.json"}))
Expand Down
368 changes: 368 additions & 0 deletions test/fixtures/pr_request_reviewer_all_reviewers_assigned.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,368 @@
{
"url": "https://api.github.com/repos/SimonLab/github_app/pulls/25",
"id": 127325565,
"html_url": "https://github.com/SimonLab/github_app/pull/25",
"diff_url": "https://github.com/SimonLab/github_app/pull/25.diff",
"patch_url": "https://github.com/SimonLab/github_app/pull/25.patch",
"issue_url": "https://api.github.com/repos/SimonLab/github_app/issues/25",
"number": 25,
"state": "open",
"locked": false,
"title": "no description",
"user": {
"login": "SimonLab",
"id": 6057298,
"avatar_url": "https://avatars1.githubusercontent.com/u/6057298?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/SimonLab",
"html_url": "https://github.com/SimonLab",
"followers_url": "https://api.github.com/users/SimonLab/followers",
"following_url": "https://api.github.com/users/SimonLab/following{/other_user}",
"gists_url": "https://api.github.com/users/SimonLab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SimonLab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SimonLab/subscriptions",
"organizations_url": "https://api.github.com/users/SimonLab/orgs",
"repos_url": "https://api.github.com/users/SimonLab/repos",
"events_url": "https://api.github.com/users/SimonLab/events{/privacy}",
"received_events_url": "https://api.github.com/users/SimonLab/received_events",
"type": "User",
"site_admin": false
},
"body": "",
"created_at": "2017-06-24T10:17:52Z",
"updated_at": "2017-06-24T17:09:42Z",
"closed_at": null,
"merged_at": null,
"merge_commit_sha": null,
"assignee": {
"login": "dwylbot",
"id": 24862484,
"avatar_url": "https://avatars3.githubusercontent.com/u/24862484?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/dwylbot",
"html_url": "https://github.com/dwylbot",
"followers_url": "https://api.github.com/users/dwylbot/followers",
"following_url": "https://api.github.com/users/dwylbot/following{/other_user}",
"gists_url": "https://api.github.com/users/dwylbot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dwylbot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dwylbot/subscriptions",
"organizations_url": "https://api.github.com/users/dwylbot/orgs",
"repos_url": "https://api.github.com/users/dwylbot/repos",
"events_url": "https://api.github.com/users/dwylbot/events{/privacy}",
"received_events_url": "https://api.github.com/users/dwylbot/received_events",
"type": "User",
"site_admin": false
},
"assignees": [
{
"login": "dwylbot",
"id": 24862484,
"avatar_url": "https://avatars3.githubusercontent.com/u/24862484?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/dwylbot",
"html_url": "https://github.com/dwylbot",
"followers_url": "https://api.github.com/users/dwylbot/followers",
"following_url": "https://api.github.com/users/dwylbot/following{/other_user}",
"gists_url": "https://api.github.com/users/dwylbot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dwylbot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dwylbot/subscriptions",
"organizations_url": "https://api.github.com/users/dwylbot/orgs",
"repos_url": "https://api.github.com/users/dwylbot/repos",
"events_url": "https://api.github.com/users/dwylbot/events{/privacy}",
"received_events_url": "https://api.github.com/users/dwylbot/received_events",
"type": "User",
"site_admin": false
}
],
"requested_reviewers": [
{
"login": "dwylbot",
"id": 24862484,
"avatar_url": "https://avatars3.githubusercontent.com/u/24862484?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/dwylbot",
"html_url": "https://github.com/dwylbot",
"followers_url": "https://api.github.com/users/dwylbot/followers",
"following_url": "https://api.github.com/users/dwylbot/following{/other_user}",
"gists_url": "https://api.github.com/users/dwylbot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dwylbot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dwylbot/subscriptions",
"organizations_url": "https://api.github.com/users/dwylbot/orgs",
"repos_url": "https://api.github.com/users/dwylbot/repos",
"events_url": "https://api.github.com/users/dwylbot/events{/privacy}",
"received_events_url": "https://api.github.com/users/dwylbot/received_events",
"type": "User",
"site_admin": false
}
],
"milestone": null,
"commits_url": "https://api.github.com/repos/SimonLab/github_app/pulls/25/commits",
"review_comments_url": "https://api.github.com/repos/SimonLab/github_app/pulls/25/comments",
"review_comment_url": "https://api.github.com/repos/SimonLab/github_app/pulls/comments{/number}",
"comments_url": "https://api.github.com/repos/SimonLab/github_app/issues/25/comments",
"statuses_url": "https://api.github.com/repos/SimonLab/github_app/statuses/cc745d25ee918af0e1ba9fd3260247219e56edcb",
"head": {
"label": "SimonLab:b2",
"ref": "b2",
"sha": "cc745d25ee918af0e1ba9fd3260247219e56edcb",
"user": {
"login": "SimonLab",
"id": 6057298,
"avatar_url": "https://avatars1.githubusercontent.com/u/6057298?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/SimonLab",
"html_url": "https://github.com/SimonLab",
"followers_url": "https://api.github.com/users/SimonLab/followers",
"following_url": "https://api.github.com/users/SimonLab/following{/other_user}",
"gists_url": "https://api.github.com/users/SimonLab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SimonLab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SimonLab/subscriptions",
"organizations_url": "https://api.github.com/users/SimonLab/orgs",
"repos_url": "https://api.github.com/users/SimonLab/repos",
"events_url": "https://api.github.com/users/SimonLab/events{/privacy}",
"received_events_url": "https://api.github.com/users/SimonLab/received_events",
"type": "User",
"site_admin": false
},
"repo": {
"id": 92847353,
"name": "github_app",
"full_name": "SimonLab/github_app",
"owner": {
"login": "SimonLab",
"id": 6057298,
"avatar_url": "https://avatars1.githubusercontent.com/u/6057298?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/SimonLab",
"html_url": "https://github.com/SimonLab",
"followers_url": "https://api.github.com/users/SimonLab/followers",
"following_url": "https://api.github.com/users/SimonLab/following{/other_user}",
"gists_url": "https://api.github.com/users/SimonLab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SimonLab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SimonLab/subscriptions",
"organizations_url": "https://api.github.com/users/SimonLab/orgs",
"repos_url": "https://api.github.com/users/SimonLab/repos",
"events_url": "https://api.github.com/users/SimonLab/events{/privacy}",
"received_events_url": "https://api.github.com/users/SimonLab/received_events",
"type": "User",
"site_admin": false
},
"private": false,
"html_url": "https://github.com/SimonLab/github_app",
"description": "a Github App to play with integrations",
"fork": false,
"url": "https://api.github.com/repos/SimonLab/github_app",
"forks_url": "https://api.github.com/repos/SimonLab/github_app/forks",
"keys_url": "https://api.github.com/repos/SimonLab/github_app/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/SimonLab/github_app/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/SimonLab/github_app/teams",
"hooks_url": "https://api.github.com/repos/SimonLab/github_app/hooks",
"issue_events_url": "https://api.github.com/repos/SimonLab/github_app/issues/events{/number}",
"events_url": "https://api.github.com/repos/SimonLab/github_app/events",
"assignees_url": "https://api.github.com/repos/SimonLab/github_app/assignees{/user}",
"branches_url": "https://api.github.com/repos/SimonLab/github_app/branches{/branch}",
"tags_url": "https://api.github.com/repos/SimonLab/github_app/tags",
"blobs_url": "https://api.github.com/repos/SimonLab/github_app/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/SimonLab/github_app/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/SimonLab/github_app/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/SimonLab/github_app/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/SimonLab/github_app/statuses/{sha}",
"languages_url": "https://api.github.com/repos/SimonLab/github_app/languages",
"stargazers_url": "https://api.github.com/repos/SimonLab/github_app/stargazers",
"contributors_url": "https://api.github.com/repos/SimonLab/github_app/contributors",
"subscribers_url": "https://api.github.com/repos/SimonLab/github_app/subscribers",
"subscription_url": "https://api.github.com/repos/SimonLab/github_app/subscription",
"commits_url": "https://api.github.com/repos/SimonLab/github_app/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/SimonLab/github_app/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/SimonLab/github_app/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/SimonLab/github_app/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/SimonLab/github_app/contents/{+path}",
"compare_url": "https://api.github.com/repos/SimonLab/github_app/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/SimonLab/github_app/merges",
"archive_url": "https://api.github.com/repos/SimonLab/github_app/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/SimonLab/github_app/downloads",
"issues_url": "https://api.github.com/repos/SimonLab/github_app/issues{/number}",
"pulls_url": "https://api.github.com/repos/SimonLab/github_app/pulls{/number}",
"milestones_url": "https://api.github.com/repos/SimonLab/github_app/milestones{/number}",
"notifications_url": "https://api.github.com/repos/SimonLab/github_app/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/SimonLab/github_app/labels{/name}",
"releases_url": "https://api.github.com/repos/SimonLab/github_app/releases{/id}",
"deployments_url": "https://api.github.com/repos/SimonLab/github_app/deployments",
"created_at": "2017-05-30T15:26:26Z",
"updated_at": "2017-05-30T15:36:26Z",
"pushed_at": "2017-06-24T10:17:53Z",
"git_url": "git://github.com/SimonLab/github_app.git",
"ssh_url": "git@github.com:SimonLab/github_app.git",
"clone_url": "https://github.com/SimonLab/github_app.git",
"svn_url": "https://github.com/SimonLab/github_app",
"homepage": null,
"size": 63,
"stargazers_count": 0,
"watchers_count": 0,
"language": "Elixir",
"has_issues": true,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 0,
"mirror_url": null,
"open_issues_count": 8,
"forks": 0,
"open_issues": 8,
"watchers": 0,
"default_branch": "initialise"
}
},
"base": {
"label": "SimonLab:initialise",
"ref": "initialise",
"sha": "e21311a9128fc38b8d2cbee79183e45bef3dfe01",
"user": {
"login": "SimonLab",
"id": 6057298,
"avatar_url": "https://avatars1.githubusercontent.com/u/6057298?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/SimonLab",
"html_url": "https://github.com/SimonLab",
"followers_url": "https://api.github.com/users/SimonLab/followers",
"following_url": "https://api.github.com/users/SimonLab/following{/other_user}",
"gists_url": "https://api.github.com/users/SimonLab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SimonLab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SimonLab/subscriptions",
"organizations_url": "https://api.github.com/users/SimonLab/orgs",
"repos_url": "https://api.github.com/users/SimonLab/repos",
"events_url": "https://api.github.com/users/SimonLab/events{/privacy}",
"received_events_url": "https://api.github.com/users/SimonLab/received_events",
"type": "User",
"site_admin": false
},
"repo": {
"id": 92847353,
"name": "github_app",
"full_name": "SimonLab/github_app",
"owner": {
"login": "SimonLab",
"id": 6057298,
"avatar_url": "https://avatars1.githubusercontent.com/u/6057298?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/SimonLab",
"html_url": "https://github.com/SimonLab",
"followers_url": "https://api.github.com/users/SimonLab/followers",
"following_url": "https://api.github.com/users/SimonLab/following{/other_user}",
"gists_url": "https://api.github.com/users/SimonLab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SimonLab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SimonLab/subscriptions",
"organizations_url": "https://api.github.com/users/SimonLab/orgs",
"repos_url": "https://api.github.com/users/SimonLab/repos",
"events_url": "https://api.github.com/users/SimonLab/events{/privacy}",
"received_events_url": "https://api.github.com/users/SimonLab/received_events",
"type": "User",
"site_admin": false
},
"private": false,
"html_url": "https://github.com/SimonLab/github_app",
"description": "a Github App to play with integrations",
"fork": false,
"url": "https://api.github.com/repos/SimonLab/github_app",
"forks_url": "https://api.github.com/repos/SimonLab/github_app/forks",
"keys_url": "https://api.github.com/repos/SimonLab/github_app/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/SimonLab/github_app/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/SimonLab/github_app/teams",
"hooks_url": "https://api.github.com/repos/SimonLab/github_app/hooks",
"issue_events_url": "https://api.github.com/repos/SimonLab/github_app/issues/events{/number}",
"events_url": "https://api.github.com/repos/SimonLab/github_app/events",
"assignees_url": "https://api.github.com/repos/SimonLab/github_app/assignees{/user}",
"branches_url": "https://api.github.com/repos/SimonLab/github_app/branches{/branch}",
"tags_url": "https://api.github.com/repos/SimonLab/github_app/tags",
"blobs_url": "https://api.github.com/repos/SimonLab/github_app/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/SimonLab/github_app/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/SimonLab/github_app/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/SimonLab/github_app/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/SimonLab/github_app/statuses/{sha}",
"languages_url": "https://api.github.com/repos/SimonLab/github_app/languages",
"stargazers_url": "https://api.github.com/repos/SimonLab/github_app/stargazers",
"contributors_url": "https://api.github.com/repos/SimonLab/github_app/contributors",
"subscribers_url": "https://api.github.com/repos/SimonLab/github_app/subscribers",
"subscription_url": "https://api.github.com/repos/SimonLab/github_app/subscription",
"commits_url": "https://api.github.com/repos/SimonLab/github_app/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/SimonLab/github_app/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/SimonLab/github_app/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/SimonLab/github_app/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/SimonLab/github_app/contents/{+path}",
"compare_url": "https://api.github.com/repos/SimonLab/github_app/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/SimonLab/github_app/merges",
"archive_url": "https://api.github.com/repos/SimonLab/github_app/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/SimonLab/github_app/downloads",
"issues_url": "https://api.github.com/repos/SimonLab/github_app/issues{/number}",
"pulls_url": "https://api.github.com/repos/SimonLab/github_app/pulls{/number}",
"milestones_url": "https://api.github.com/repos/SimonLab/github_app/milestones{/number}",
"notifications_url": "https://api.github.com/repos/SimonLab/github_app/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/SimonLab/github_app/labels{/name}",
"releases_url": "https://api.github.com/repos/SimonLab/github_app/releases{/id}",
"deployments_url": "https://api.github.com/repos/SimonLab/github_app/deployments",
"created_at": "2017-05-30T15:26:26Z",
"updated_at": "2017-05-30T15:36:26Z",
"pushed_at": "2017-06-24T10:17:53Z",
"git_url": "git://github.com/SimonLab/github_app.git",
"ssh_url": "git@github.com:SimonLab/github_app.git",
"clone_url": "https://github.com/SimonLab/github_app.git",
"svn_url": "https://github.com/SimonLab/github_app",
"homepage": null,
"size": 63,
"stargazers_count": 0,
"watchers_count": 0,
"language": "Elixir",
"has_issues": true,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 0,
"mirror_url": null,
"open_issues_count": 8,
"forks": 0,
"open_issues": 8,
"watchers": 0,
"default_branch": "initialise"
}
},
"_links": {
"self": {
"href": "https://api.github.com/repos/SimonLab/github_app/pulls/25"
},
"html": {
"href": "https://github.com/SimonLab/github_app/pull/25"
},
"issue": {
"href": "https://api.github.com/repos/SimonLab/github_app/issues/25"
},
"comments": {
"href": "https://api.github.com/repos/SimonLab/github_app/issues/25/comments"
},
"review_comments": {
"href": "https://api.github.com/repos/SimonLab/github_app/pulls/25/comments"
},
"review_comment": {
"href": "https://api.github.com/repos/SimonLab/github_app/pulls/comments{/number}"
},
"commits": {
"href": "https://api.github.com/repos/SimonLab/github_app/pulls/25/commits"
},
"statuses": {
"href": "https://api.github.com/repos/SimonLab/github_app/statuses/cc745d25ee918af0e1ba9fd3260247219e56edcb"
}
},
"merged": false,
"mergeable": false,
"rebaseable": false,
"mergeable_state": "dirty",
"merged_by": null,
"comments": 4,
"review_comments": 0,
"maintainer_can_modify": false,
"commits": 1,
"additions": 4,
"deletions": 1,
"changed_files": 1
}
Loading