-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Flutter navigation menu initial implementation #2
Conversation
Most tutorials and demos that pertain to menus that I find use drawers and not full-screen menus. I feel like I should have to use the Navigator and treat the If I am in Page 1, go to theMenu, choose Page 2 and navigate to it, users shouldn't be able to "return back to the menu", as I don't consider it a page. In fact it should go to Page 1, instead of |
I've implemented a Sliding Menu that is shown using a Stack.
However, I highly doubt how this could be done for every single page of the application. I've tried exploring using the ":drawer" property of I went through the aforementioned route but I highly doubt I'll continue with it. I'll probably repurpose All of this just because I want the menu to be easily accessible on all pages, doesn't have "page behaviour" (it shouldn't be treated as a page in the |
I think I cracked a way that makes sense and satisfies the following needs:
The last requirement was what made the decision harder for me. I didn't find any guides that wouldn't use a I'm going to go for a way of named routes for links within the menu, even if Flutter states that:
The only guides that I found for this to work use named routes. This is the only way to persist the So this is like the third time I went back to 0 to start anew but I hope this is the proper way of getting this to work now 🤞 |
Still in the process of documenting the findings and going over the two possible solutions. Taking my time to not forget any important details. Will go over the simple version and document it tomorrow. |
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 3
Lines ? 72
Branches ? 0
========================================
Hits ? 72
Misses ? 0
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This should be ready for review. Added CI, tests and readme with both options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this. 👍
Strong preference for removing the more complex one. ✂️
But we can keep it here and just use the simpler one in our App
. ✅
Thanks @LuchoTurtle 👌 |
addresses #1
This is the initial implementation of the repository, meant to showcase the progressive UI exemplified in dwyl/app#305.
This repo should show simple full-screen navigation between pages, as detailed in dwyl/app#305.