consistent-return

[SimonLab]

http://eslint.org/docs/rules/consistent-return

consistent-return: [2, { "treatUndefinedAsUnspecified": true }]

Consistency is good!

[jrans]

@SimonLab do we really want to not be able to do this:

function bar(condition) {
    if (condition) {
        return undefined;
    }
    return true;
}

"treatUndefinedAsUnspecified": true stops this

[nelsonic]

hmm... happy to enforce this until/unless it becomes onerous.
I personally _always_ return something; but I don't know if it's necessary ...
Agree that "consistency is good." 👍

[SimonLab]

Just one thing which feels strange with this rule is to add a return in front of an async function:

'use strict';

var fs = require('fs');

module.exports = function (err) {
  if (err) {
    return new Error('error');
  }

  return fs.writeFile('./myfile', 'the content', function (error) {
    console.log(error);
  });
};

When using multiple async functions it started to look a bit weird.
I'm tempted to disable this rule. @jrans @eliasCodes @Shouston3 @nelsonic any thoughts on this?

[samhstn]

Agreed @SimonLab I think this should be disabled:

consistent-return: "off"

[jrans]

I'm undecided, I've outlined the modification I'd make but will let you guys decide.