-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test elias rules #222
test elias rules #222
Conversation
@SimonLab Can you reference the issues that this PR resolves? so once merged will close them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one issue with duplicate configuration of 'max-len'
@@ -1,5 +1,33 @@ | |||
module.exports = { | |||
"space-infix-ops": ["error", {"int32Hint": false}], // https://github.com/dwyl/goodparts/issues/32 | |||
"max-len": ["error", 80], // https://github.com/dwyl/goodparts/issues/186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate max-len
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this one as other is more exact
Ready for review!
related to:
Resolves #219
Resolves #218
Resolves #217
Resolves #216
Resolves #215
Resolves #214
Resolves #213
Resolves #212
Resolves #211
Resolves #210
Resolves #209
Resolves #208
Resolves #207
Resolves #205
Resolves #204
Resolves #202
Resolves #201
Resolves #199
Resolves #186
Resolves #153
Resolves #152
Resolves #151
Resolves #150
Resolves #144
Resolves #143
Resolves #139
Resolves #136
Resolves #134
Resolves #132
Resolves #129
Resolves #126
Resolves #121
Resolves #119
Resolves #112
Resolves #55
Resolves #54
Resolves #53
Resolves #50
Resolves #39
Resolves #38
Resolves #34
Resolves #32
Resolves #20
Resolves #17