in-review label: how and when to use it

[nelsonic]

The in-review label is reserved for the team member / QA reviewing the Pull Request code/change. The reviewer applies the label to communicate with the rest of the team that they are actively reviewing the PR and to avoid duplication of effort.
We used to require reviewers to write a comment on the PR (typically a 👀 :eyes: emoji) to indicate that they were reviewing the PR, but we decided that using a label instead of a comment was clearer (especially to non-technical team members/stakeholders) and worked well for us.

only the reviewer should apply the in-review label. this will start the clock on their Timer. 👍

Process Automation enhancement help wanted

Once the pull request has been merged @dwylbot 🤖 will remove the in-review label from the Pull Request and apply the please-test label. 🛎
Additionally/Optionally @dwylbot 🤖 will parse the commit messages in the PR for any issue numbers and apply the please-test label to those issues too. ✨

[iteles]

Is this the in-review label as used in the PRs?

On issues, teams have tended to move issues from in-progress to in-review once they have opened a PR on it, to ensure that they can easily identify what has already been worked on in the backlog and what still requires work. This might not be the best way of doing this, so I wanted to bring it up here to make sure the differentiation was able to be clarified.

[nelsonic]

When a story is "code complete" by the Developer(s) they will remove the in-progress label.
I would suggest the story gets the awaiting-review label applied. see: #49

ideally the act of assigning the PR to Reviewer(s) will do all the necessary label changing.

[iteles]

Perfect 👍

[iteles]

Note: I disagree that dwylbot should automatically apply a 'please test' label. Often there is a lag between a merge and a deployment and we've had POs complain before that things have been assigned to them prematurely (it just looks to them like the issues hasn't been fixed) which is an ineffective use of everyone's time.

I'll post a suggested solution asap but thoughts welcome!

[iteles]

@nelsonic Label added to repo and description added to readme with reference to this issue. Can we close it?