Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: add documentation label description to README.md closes #141 #142

Merged
merged 1 commit into from
Sep 29, 2022
Merged

PR: add documentation label description to README.md closes #141 #142

merged 1 commit into from
Sep 29, 2022

Conversation

nelsonic
Copy link
Member

Micro PR to:

image

Thanks.

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality awaiting-review An issue or pull request that needs to be reviewed T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. documentation Improvements or additions to documentation labels Sep 29, 2022
@nelsonic nelsonic requested a review from SimonLab September 29, 2022 06:31
@nelsonic nelsonic temporarily deployed to liveview-chat-example September 29, 2022 06:31 Inactive
@nelsonic nelsonic mentioned this pull request Sep 29, 2022
Closed
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #142 (0ca85fa) into main (c903bf0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           83        83           
=========================================
  Hits            83        83

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SimonLab
SimonLab approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@SimonLab SimonLab merged commit a847552 into main Sep 29, 2022
@SimonLab SimonLab deleted the add-documentation-label-description-issue-#141 branch September 29, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab