Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Fail Handled #64

Merged
merged 3 commits into from
Apr 20, 2017
Merged

Sync Fail Handled #64

merged 3 commits into from
Apr 20, 2017

Conversation

jackcarlisle
Copy link
Member

@jackcarlisle jackcarlisle commented Apr 18, 2017 •
edited by nelsonic
Loading

  • adds proper error handling
  • adds tests

#63

@jackcarlisle jackcarlisle changed the title [WiP] Sync Fail Handled Sync Fail Handled Apr 18, 2017
@jackcarlisle jackcarlisle changed the title Sync Fail Handled [WiP] Sync Fail Handled Apr 18, 2017
@jackcarlisle jackcarlisle changed the title [WiP] Sync Fail Handled Sync Fail Handled Apr 19, 2017
@jackcarlisle jackcarlisle requested a review from nelsonic April 19, 2017 15:33
@nelsonic
Copy link
Member

@jackcarlisle thanks for assigning the PR. should we also update the description from "Not Ready"? 😉
image

@nelsonic nelsonic added the in-review Issue or pull request that is currently being reviewed by the assigned person label Apr 20, 2017
nelsonic
nelsonic approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcarlisle error handling and tests look good. thanks! 🎉

@nelsonic nelsonic merged commit fa85fa4 into master Apr 20, 2017
@nelsonic nelsonic deleted the sync-fail branch April 20, 2017 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcarlisle @nelsonic