Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Error: release command failed - aborting deployment [Review Apps] #407

Open
1 task
nelsonic opened this issue Aug 15, 2023 · 6 comments
Open
1 task

Chore: Error: release command failed - aborting deployment [Review Apps] #407

nelsonic opened this issue Aug 15, 2023 · 6 comments
Assignees
@LuchoTurtle
Labels
chore a tedious but necessary task often paying technical debt priority-3 Third priority. Considered "Nice to Have". Not urgent. T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

Seeing the following error on the #405 PR:
https://github.com/dwyl/mvp/actions/runs/5864648540/job/15900061668#step:5:1515
image

  2023/08/15 07:22:30 listening on [fdaa:0:78d4:a7b:173:9fb5:5989:2]:22 (DNS: [fdaa::3]:53)
  [    2.316331] reboot: Restarting system
  machine restart policy set to 'no', not restarting
Error: release command failed - aborting deployment. 
error release_command machine 784e677f2265d8 exited with non-zero status of 1

Todo
@nelsonic nelsonic added T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies chore a tedious but necessary task often paying technical debt BLOCKED :fire: Core team's HIGHEST priority, blocking critical work tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Aug 15, 2023
nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
restart_limit = 5 in fly.toml #407
b395a3f
@nelsonic nelsonic mentioned this issue Aug 15, 2023
Merged
nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
--restart on-fail in .github/scripts/review-apps.sh for #407
0ac1010
@nelsonic
Copy link
Member Author

Tried adding the --restart on-fail to the deploy in the .github/scripts/review-apps.sh and it didn't have any effect:
https://github.com/dwyl/mvp/actions/runs/5864913681/job/15900837908#step:5:26
image

deploy updated application
Usage:
Error: unknown flag: --restart

🙄

@nelsonic
Copy link
Member Author

Posted on the thread: https://community.fly.io/t/i-am-getting-release-command-failed/14775/4

@nelsonic
Copy link
Member Author

@LuchoTurtle please pick this up when you get a moment. You have admin access to everything.
If no progress can be made we may need to temporarily disable the Review Apps Script [again...]:

mvp/.github/workflows/pr.yml

Lines 87 to 88 in 957efcc

- name: Run Review App Script
run: ./.github/scripts/review-apps.sh

nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
temporarily disable the Review Apps Script ref: #407
c39d6fb
nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
temporarily disable API tests which rely on review app ... #407 🙄
8ecdcc1
nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
revert " --restart on-fail" in .github/scripts/review-apps.sh as "Err…
634be19 
…or: unknown flag: --restart" ... #407 (comment)
nelsonic added a commit that referenced this issue Aug 15, 2023
@nelsonic
Temporarily Disable Review Apps Script as deploy is NOT Working #407
7703024
@nelsonic
Copy link
Member Author

I've commented out the Review Apps Script and API Tests (which depend on the Review App) in your PR #405
Because if the Review App deployment isn't working and we cannot find a solution on the forums/google then we must move on with our work and return to this next week ... ⏳ hopefully someone from Fly.io will respond on the forum post. 🤞

@nelsonic nelsonic removed the BLOCKED :fire: Core team's HIGHEST priority, blocking critical work label Aug 15, 2023
@nelsonic nelsonic mentioned this issue Aug 15, 2023
Merged
2 tasks
@LuchoTurtle
Copy link
Member

Still no response from fly.io... https://community.fly.io/t/i-am-getting-release-command-failed/14775/4
😞

Would it make sense to uncomment the Review App pipeline to see if it works? Perhaps it was just an hiccup with their servers 🤔

@nelsonic nelsonic added the priority-3 Third priority. Considered "Nice to Have". Not urgent. label Aug 21, 2023
@nelsonic
Copy link
Member Author

Yeah, the deploy from main appears to be working:
https://github.com/dwyl/mvp/actions/runs/5924458274/job/16062081889
image

So we could attempt to re-enable review apps. But not definitely urgent. 👌

LuchoTurtle added a commit that referenced this issue Sep 12, 2023
@LuchoTurtle
chore: Reactivating Review Apps to check if it works. #407
4fe9b8e
@LuchoTurtle LuchoTurtle mentioned this issue Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
chore a tedious but necessary task often paying technical debt priority-3 Third priority. Considered "Nice to Have". Not urgent. T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PR] Reactivating Review Apps to check if it works. dwyl/mvp
2 participants
@nelsonic @LuchoTurtle