Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: DRY the get_person_id/1 function duplicated in app_live and stats #409

Closed
4 tasks done
nelsonic opened this issue Aug 21, 2023 · 5 comments
Closed
4 tasks done

Chore: DRY the get_person_id/1 function duplicated in app_live and stats #409

nelsonic opened this issue Aug 21, 2023 · 5 comments
Assignees
@panoramix360
Labels
chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Aug 21, 2023 •
edited by panoramix360
Loading

As noted by @LuchoTurtle in #399 (comment) the get_person_id/1 function is duplicated in lib/app_web/live/stats_live.ex

Todo

  • create a new file for person-related functions e.g: lib/app/person.ex
  • create the corresponding tests in test/app/person_test.exs
  • lift & shift the function(s) that are reusable and place them, with docs in lib/app/person.ex
  • Create a PR or include this as part of other work.
@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished chore a tedious but necessary task often paying technical debt tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written documentation Improvements or additions to documentation labels Aug 21, 2023
@nelsonic nelsonic mentioned this issue Aug 21, 2023
Merged
2 tasks
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Aug 21, 2023
@panoramix360
Copy link
Collaborator

hey! can I take this one?

(feel free to point me to another issue that you might be needing help, it could be even on another repo :D)

@LuchoTurtle
Copy link
Member

Go for it :)

@panoramix360 panoramix360 self-assigned this Aug 21, 2023
@nelsonic
Copy link
Member Author

@panoramix360 yeah, as @LuchoTurtle says go for it and create a PR. If you get stuck ping us. Thanks! 🙏

@nelsonic nelsonic moved this from 🔖 Ready for Development to 🏗 In progress in dwyl app kanban Aug 21, 2023
@panoramix360
Copy link
Collaborator

Hey guys! sorry for the delay on this.

Here is the PR #415 :D

Let me know what you think!

@nelsonic
Copy link
Member Author

nelsonic commented Sep 6, 2023

@panoramix360 no need to apologise. 😉
Thanks for the PR. Merged. 👌

@nelsonic nelsonic closed this as completed Sep 6, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in dwyl app kanban Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panoramix360 panoramix360

Labels
chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @panoramix360 @LuchoTurtle